-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unread mention [WPB-5786] #2663
Conversation
Test Results2 599 tests - 399 2 526 ✔️ - 351 28s ⏱️ - 2m 15s Results for commit 84e4059. ± Comparison against base commit 494d5a7. This pull request removes 2998 and adds 2599 tests. Note that renamed tests count towards both.
This pull request removes 121 skipped tests and adds 73 skipped tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2663 +/- ##
=============================================
- Coverage 58.84% 58.84% -0.01%
Complexity 7 7
=============================================
Files 1188 1188
Lines 46329 46320 -9
Branches 4380 4380
=============================================
- Hits 27264 27255 -9
- Misses 17107 17108 +1
+ Partials 1958 1957 -1
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
I think it does the same as the
This change is to make it manually instead of let SQL do that itself when message id changes, but the logic generally is not changed at all, so maybe the problem is somewhere else? |
i just tested this PR and compared it to prod and in both apps this bug did not reproduce so it is fixed by something else |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Causes (Optional)
Unread mention event was not clearing in conversation list
Solutions